[WIP]Updated VM With Contracts #1598
Draft
+4,058
−1,156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I don't think this belongs here
richardpringle
changed the title
samliok
force-pushed
the
updated-contracts-vm
branch
from
2fd9b43
to
1c0dffa
Compare
|
|
||
| // Specify all statekeys Execute can touch | ||
| func (c *Call) StateKeys(actor codec.Address, actionID ids.ID) state.Keys { | ||
| return state.Keys{} |
There was a problem hiding this comment.
I'm guessing this is a TODO?
This needs to be part of the Call struct, I'm pretty sure.
Comment on lines
+39
to
+47
| // prefix's all contract related keys | ||
| contractPrefix = 0x4 | ||
| contractBytePrefix = 0x5 | ||
| // prefix's all contract state keys | ||
| contractStatePrefix = 0x0 | ||
| // contract bytes prefixc, prefix's ids -> contract bytes | ||
| // contract state prefix, prefix's ids -> contract state | ||
| // contract ID prefix[ contractPrefix -> contractIDPrefix ] | ||
| contractIDPrefix = 0x2 |
There was a problem hiding this comment.
Any thoughts on putting this stuff in the runtime package?
Comment on lines
+191
to
+201
| func HeightKey() (k []byte) { | ||
| return heightKey | ||
| } | ||
|
|
||
| func TimestampKey() (k []byte) { | ||
| return timestampKey | ||
| } | ||
|
|
||
| func FeeKey() (k []byte) { | ||
| return feeKey | ||
| } |
There was a problem hiding this comment.
These variables aren't used anywhere else, any reason not to inline them?
There was a problem hiding this comment.
Seems weird that this is part of the vm package
| } | ||
| reply.Amount = balance | ||
| return err | ||
| } |
There was a problem hiding this comment.
This whole thing needs to be spun out into an rpc package
|
|
||
| // When registering new auth, ALWAYS make sure to append at the end. | ||
| AuthParser.Register(&auth.ED25519{}, auth.UnmarshalED25519), | ||
| AuthParser.Register(&auth.SECP256R1{}, auth.UnmarshalSECP256R1), |
There was a problem hiding this comment.
Why do we use two different curves?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOS