-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_v2x_msgs): add virtual gate messages #77
feat(autoware_v2x_msgs): add virtual gate messages #77
Conversation
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
9493752
to
c9106cf
Compare
Signed-off-by: Takagi, Isamu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test approval
It's a good design. Will the PR be merged in the roadmap? |
Signed-off-by: Takagi, Isamu <[email protected]>
Thank you. Since it has been discussed several times, I think it would be a good idea to merge and try it out.
Yes, the v2x component does not exist yet, so we need to create a new one. |
Once the maintainer information is updated, the PR looks good to me. |
Signed-off-by: Takagi, Isamu <[email protected]>
…are_msgs into feat/add-v2x-messages
Maybe we can change the interface name to something like:
|
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
@mitsudome-r @yukkysaito Similar messages are "Signal Request Message" and "Signal Status Message" called in ITS standards. So what about the following names?
|
This pull request has been automatically marked as stale because it has not had recent activity. |
I don't mind with virtual gate messages for now. |
Description
Add virtual gate message. See README for details.
Related links
autowarefoundation/autoware.universe#2703
Tests performed
Not applicable.
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.