Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_v2x_msgs): add virtual gate messages #77

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Dec 7, 2023

Description

Add virtual gate message. See README for details.

Related links

autowarefoundation/autoware.universe#2703

Tests performed

Not applicable.

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi self-assigned this Dec 7, 2023
@isamu-takagi isamu-takagi marked this pull request as ready for review January 24, 2024 03:59
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test approval

@mitsudome-r mitsudome-r requested review from dimethylether261 and removed request for dimethylether261 January 29, 2024 05:16
@evshary
Copy link
Member

evshary commented Mar 6, 2024

It's a good design. Will the PR be merged in the roadmap?
Also, if I understand correctly, the router in the v2x component will be implemented in the future, right?

@isamu-takagi
Copy link
Contributor Author

It's a good design. Will the PR be merged in the roadmap?

Thank you. Since it has been discussed several times, I think it would be a good idea to merge and try it out.
@mitsudome-r @yukkysaito What do you think? Would it be better to separate the package so that it can be seen that it is a prototype message because it has not been sufficiently tested?

Also, if I understand correctly, the router in the v2x component will be implemented in the future, right?

Yes, the v2x component does not exist yet, so we need to create a new one.

@mitsudome-r
Copy link
Member

Once the maintainer information is updated, the PR looks good to me.

autoware_v2x_msgs/msg/VirtualGateAreaCommand.msg Outdated Show resolved Hide resolved
autoware_v2x_msgs/msg/VirtualGateAreaCommand.msg Outdated Show resolved Hide resolved
autoware_v2x_msgs/msg/VirtualGateAreaCommand.msg Outdated Show resolved Hide resolved
autoware_v2x_msgs/msg/VirtualGateAreaStatus.msg Outdated Show resolved Hide resolved
@mitsudome-r
Copy link
Member

Maybe we can change the interface name to something like:

  • Lock Road Interface
  • Acquire Road Interface
  • Request to Pass Interface

isamu-takagi and others added 4 commits March 8, 2024 18:37
@isamu-takagi
Copy link
Contributor Author

Maybe we can change the interface name to something like:

@mitsudome-r @yukkysaito Similar messages are "Signal Request Message" and "Signal Status Message" called in ITS standards. So what about the following names?

  • RoadLockRequest.msg / RoadLockStatus.msg
  • AcquireRoadRequest.msg / AcquireRoadStatus.msg
  • RightOfWayRequest.msg / RightOfWayStatus.msg
  • PassPermitRequest.msg / PassPermitStatus.msg

Copy link

stale bot commented May 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale label May 8, 2024
@mitsudome-r
Copy link
Member

I don't mind with virtual gate messages for now.

@stale stale bot removed the status:stale label Jul 11, 2024
@mitsudome-r mitsudome-r merged commit 6f4f478 into autowarefoundation:main Jul 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants