set the dynamodb query command Limit option to options.limit by default

autopulated · May 1, 2024 · 5f206c0 · 5f206c0
1 parent 4727a7d
commit 5f206c0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -920,9 +920,11 @@ class BaseModel {
             ExpressionAttributeValues: mergedExprAttributeValues,
             ExpressionAttributeNames: mergedExprAttributeNames,
             ...(ExclusiveStartKey && {ExclusiveStartKey}),
-            // TODO: not sure if this will mess up pagination?
-            // set the dynamodb Limit to the options limit, or the maximum supported, so that we don't evaluate more items than necessary
-            // ...(options.limit && {Limit:options.limit})
+            // set the dynamodb Limit to the options limit, so that we don't
+            // evaluate more items than necessary. If making a query with a
+            // filter expression it may make sense to specify a larger limit,
+            // in which case that can be specified in otherOptions.Limit
+            ...(options.limit && {Limit: options.limit})
         }, otherOptions);
     }
 }