-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pkginfo size output #130
base: main
Are you sure you want to change the base?
Conversation
Adds additional keys from cataloginfo to processor output: - installer_item_size: size of the source pkg sent to the processor - installed_size: size of the pkg contents once installed, as reported by the pkg
remove erroneous additional newline
@grahampugh as discussed in Slack last week, I've made the necessary changes to add size outputs to this processor and tested them successfully. This should be ready to go! |
not able to be fetched with some test recipes
Curious as to why you removed installed_size? |
It was failing with a KeyError on a few test recipes and I couldn't figure out where it was having trouble getting the data. Happy to re-add it but I might need some guidance on troubleshooting the issue. The installer size has been working great. |
To be clear, I don't require installed_size to be in there - I just wondered why the reason for removing. If it's not working and you don't need it, feel free to leave it out. |
Yeah, I'm trying to get it working again mainly to learn what I'm missing. I'll likely be making a few more commits to this branch as I poke at it and will let you know if/when it's working and ready. |
@grahampugh at long last, this is working and should be ready for review! I ended up breaking down each function and stepping through them to understand where the data was coming from and how it was flowing. Eventually I realized |
os.path.getsize()
to getinstaller_item_size
in bytesinstaller_item_size