Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #[async_trait] attribute not being correctly detected when its re-exported from another crate #164

Merged
merged 5 commits into from
Dec 1, 2023
Merged

fix #[async_trait] attribute not being correctly detected when its re-exported from another crate #164

merged 5 commits into from
Dec 1, 2023

Conversation

mellowagain
Copy link
Member

@mellowagain mellowagain commented Dec 1, 2023 •
edited
Loading

Checklist

  • Changelog updated

@mellowagain mellowagain requested a review from a team December 1, 2023 11:48
gagbo
gagbo reviewed Dec 1, 2023
View reviewed changes
autometrics-macros/src/lib.rs Outdated Show resolved Hide resolved
gagbo
gagbo approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@gagbo gagbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit but otherwise good to me :)

@mellowagain mellowagain enabled auto-merge (squash) December 1, 2023 12:30
@mellowagain mellowagain merged commit 8600582 into main Dec 1, 2023
1 check passed
@mellowagain mellowagain deleted the atfix branch December 1, 2023 12:33
@mellowagain mellowagain mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagbo gagbo gagbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mellowagain @gagbo