Implement repository fields and support for filtered caller tracking
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagbo
force-pushed
the
am-38-implement-golang-details
branch
2 times, most recently
from
e0fa6f4 to
2a3a4d6
Compare
Fixes AM-41
The parent tracking is span-based (using `(TraceID, SpanId)` as keys) It falls back to the previous method (`runtime.Callers()` analysis) if the function id for a given span is missing from the global state. To prevent the global state from ballooning memory usage, the entries in the span-to-functionIDs table are deleted as part of the cleanup code in `Instrument` (that is why some goroutines outliving their callers with weird scheduling might miss the function id in the global state.) This solution deals well with functions spawning multiple goroutines, but the caller info will be "enhanced" (i.e. with Autometrics annotated functions in the parent field) only if the context created by autometrics.PreInstrument is properly passed to callees, which is a task followed in #78 Fixes: AM-42
This allow library users to reuse the context augmented with Autometrics, so the tracing and caller information can be a lot more precise Fixes: #78
gagbo
force-pushed
the
am-38-implement-golang-details
branch
from
2a3a4d6 to
daa9f85
Compare
Instead of erroring out when some arguments cannot be inspected for context inspection, we log the information.
This will fix the builds that are downloaded, but not the ones from go install
The context of a HTTP request is not assignable, so we need to read from the existing context and create a new one
This was
linked to
issues
Nov 6, 2023
mellowagain
approved these changes
Nov 13, 2023
| } | ||
| } | ||
| } else { | ||
| // TODO: log that autometrics cannot detect multi-nested contexts instead of errorring |
There was a problem hiding this comment.
Oh yeah I'll do that later, I don't know the "Go" way of writing logs in library packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing parts to meet the upcoming Autometrics 1.0 spec
Checklist