Split out link text-decoration properties for Safari compatibility #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acusti
changed the title
Safari doesn’t support specifying text-decoration-thickness in the text-decoration shorthand: https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration#browser_compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari doesn’t support specifying text-decoration-thickness in the text-decoration shorthand. Beyond that, Safari also seems to have trouble handling CSS custom properties within the shorthand syntax. So I just split out the individual
text-decoration-colorandtext-decoration-thicknessproperties into their own declarations and custom properties and defined them as needed.To illustrate the issue, here’s how the Setup part of the A Builder’s Tour of Automerge looks on desktop Safari:
(initially i was just confused why the Info box, for example, didn’t link to the repo where i could find the code mentioned there)