Export the LoadSyncMessage function #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Meier <[email protected]>
|
cc @ConradIrwin |
|
Build failed on 1 runner due to a panic in the static linter 🤣 https://github.com/automerge/automerge-go/actions/runs/11534888217/job/32194058725?pr=31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: this change makes an existing loadSyncMessage function public by capitalising it.
I'd like to have access to the LoadSyncMessage function so that I can inspect a received message before merging it into the document. This would allow me to do things like:
Right now I can only achieve this by accepting the change, checking it, and then forking the document based on the previous heads in order to "rollback" which is obviously more expensive than I'd like.
Thanks!