Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can disable ability and scope checking #458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

margarizaldi
Copy link

@margarizaldi margarizaldi commented Jul 18, 2024

Changes

It can disable the ability and scope checking in Gate to not bother application that implement its own RBAC, especially for those having existing permissions with : character and takes advantage of can method such as spatie/permission.

I think this is important since:

  • The Gate interception avoids us to use colon as permission name for our own rbac implementation
  • using colon, such as view:user, create:post, etc is common practice
  • Auth0 RBAC feature is optional after all

Also I believe that this PR won't introduce any breaking change.

References

#457

Testing

Anyone please help me adding tests to this PR 😃

Contributor Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant