Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for checking multiple JWTMiddlewares #185

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

noamsan
Copy link

@noamsan noamsan commented Dec 5, 2022

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

🔧 Changes

📚 References

🔬 Testing

@ewanharris
Copy link
Contributor

Thanks for the PR @noamsan!

I have a concern about potentially including this type of functionality in the middleware vs potentially documenting how to chain the middleware. My concern is whether a single chaining solution would fit all use cases (some might want to only continue if all pass rather than just one for example).

Do you see any reason why documentation on chaining multiple JWTMiddleware instances might not be enough to cover this?

@noamsan
Copy link
Author

noamsan commented Aug 9, 2023

Hey @ewanharris - if chaining covers the case of "two JWT issuers but only one is required to pass", then documentation on chaining should definitely suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants