Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh the ASP.NET MVC Owin quickstart #10296

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Refresh the ASP.NET MVC Owin quickstart #10296

merged 6 commits into from
Sep 14, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Sep 5, 2023 •
edited
Loading

Refresh the quickstart to align more with the latest ASP.NET Core MVC quickstart.

  • Remove a few unnecessary includes to make it easier to see the whole.
  • Fix some typos
  • Simplify some snippets to stick to what we need to add, rather than provide a full blown tutorial-alike experience
  • Update path to sample app after having changes the sample set up

@frederikprijck frederikprijck requested a review from a team as a code owner September 5, 2023 15:11
stevehobbsdev
stevehobbsdev reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just left a few suggestions to consider.

articles/quickstart/webapp/aspnet-owin/01-login.md Outdated Show resolved Hide resolved
articles/quickstart/webapp/aspnet-owin/01-login.md Outdated Show resolved Hide resolved
articles/quickstart/webapp/aspnet-owin/01-login.md Show resolved Hide resolved
articles/quickstart/webapp/aspnet-owin/01-login.md Show resolved Hide resolved
articles/quickstart/webapp/aspnet-owin/01-login.md Outdated Show resolved Hide resolved
articles/quickstart/webapp/aspnet-owin/01-login.md Outdated Show resolved Hide resolved
articles/quickstart/webapp/aspnet-owin/01-login.md Outdated Show resolved Hide resolved
articles/quickstart/webapp/aspnet-owin/01-login.md Outdated Show resolved Hide resolved
@frederikprijck frederikprijck merged commit 004f295 into master Sep 14, 2023
2 checks passed
@frederikprijck frederikprijck deleted the feat/asp-owin-modernize branch September 14, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikprijck @stevehobbsdev