New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align json property 'cross_origin_authentication' with api docs #555

Merged

jimmyjames merged 1 commit into auth0:master from Jojo134:master

Jul 26, 2023

Contributor

Jojo134 commented Jul 19, 2023

Changes

fixes Add cross_origin_authentication to the response model for the SDK #554
align attribute with the response documentation https://auth0.com/docs/api/management/v2/clients/get-clients

References

go implementation https://github.com/auth0/go-auth0/blob/main/management/client.go#L68C2-L68C2
Management API docs https://auth0.com/docs/api/management/v2/clients/get-clients

Testing

This just change from which attribute of the json the value is extracted

This change has been tested on the latest version of the platform/language

Checklist

I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors


          align json property with api docs

d580aec

Jojo134 requested a review from a team as a code owner

July 19, 2023 14:38

jimmyjames approved these changes

View reviewed changes

Contributor

jimmyjames left a comment

Looks good, thanks for the PR! 🚀

jimmyjames merged commit f41662f into auth0:master

5 checks passed

jimmyjames mentioned this pull request

Release 2.6.0 #559

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet