[SDK-4400] Support Organization Name on Authorize URL #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poovamraj
previously approved these changes
Jul 18, 2023
stevehobbsdev
requested changes
Jul 18, 2023
| if (isEmpty(orgNameClaim)) { | ||
| throw new IdTokenValidationException("Organization name (org_name) claim must be a string present in the ID token"); | ||
| } | ||
| if (!org.equalsIgnoreCase(orgNameClaim)) { |
There was a problem hiding this comment.
I've made a mistake here @jimmyjames, please see the internal discussion. This should not strictly be an ignore-case check but should instead be a check against the claim value, and lowercased org (subtle difference).
There was a problem hiding this comment.
Thanks @stevehobbsdev - I pushed a new commit to address this.
jimmyjames
force-pushed
the
support-org-name
branch
from
afcd742
to
9a4b682
Compare
poovamraj
approved these changes
Jul 18, 2023
stevehobbsdev
approved these changes
Jul 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using the
org_nameauthorize parameter, as well as support for verifying theorg_nameclaim.