Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Spring Boot 3 and use the Okta Spring Boot Starter #21

Merged
merged 13 commits into from
Oct 26, 2023

Conversation

jimmyjames
Copy link
Contributor

@jimmyjames jimmyjames commented Oct 11, 2023

Changes

Updates the sample to use latest Spring Boot and the Okta Spring Boot Starter. This PR updates both the Servlet and Reactive samples. Changes include:

  • Update to Spring Boot 3.1.4
  • Update to Gradle 8.3
  • Use the okta-spring-boot-starter instead of manually configuring Spring Security
  • Update thymeleaf templates to fix deprecation warnings

A corresponding PR will be made to the quickstart article prior to merging this change.

@jimmyjames jimmyjames added the review:medium Medium review label Oct 11, 2023
@jimmyjames jimmyjames requested a review from a team as a code owner October 11, 2023 23:05
@jimmyjames
Copy link
Contributor Author

Circle failing due to not executing with the required Java 17

@jimmyjames
Copy link
Contributor Author

Circle failing due to not executing with the required Java 17

That seems to be fixed, now an issue with the functional test, will investigate.

@jimmyjames
Copy link
Contributor Author

That seems to be fixed, now an issue with the functional test, will investigate.

Issue was the tenant did not have the updated callback URL in its allowed list; that has been updated and test is passing.

.circleci/config.yml Outdated Show resolved Hide resolved
mvc-login/build.gradle Outdated Show resolved Hide resolved
mvc-login/build.gradle Outdated Show resolved Hide resolved
webflux-login/build.gradle Outdated Show resolved Hide resolved
webflux-login/build.gradle Outdated Show resolved Hide resolved
Copy link

@mraible mraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions for improvement.

poovamraj
poovamraj previously approved these changes Oct 23, 2023
Copy link
Contributor

@poovamraj poovamraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmyjames
Copy link
Contributor Author

Quickstart article changes here: auth0/docs#10323

Once that is approved I'll merge this and then the docs PR.

frederikprijck
frederikprijck previously approved these changes Oct 24, 2023
Copy link
Contributor

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few comments to align with comments made on the docs. All good to go without, but would make sense to ensure we either update both sample and quickstart, or update none of the two.

mvc-login/build.gradle Outdated Show resolved Hide resolved
webflux-login/build.gradle Outdated Show resolved Hide resolved
@jimmyjames jimmyjames merged commit 79d0930 into master Oct 26, 2023
7 checks passed
@jimmyjames jimmyjames deleted the update-login-samples branch October 26, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants