-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Spring Boot 3 and use the Okta Spring Boot Starter #21
Conversation
Circle failing due to not executing with the required Java 17 |
That seems to be fixed, now an issue with the functional test, will investigate. |
Issue was the tenant did not have the updated callback URL in its allowed list; that has been updated and test is passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions for improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jimmyjames
Quickstart article changes here: auth0/docs#10323 Once that is approved I'll merge this and then the docs PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few comments to align with comments made on the docs. All good to go without, but would make sense to ensure we either update both sample and quickstart, or update none of the two.
204481e
Co-authored-by: Frederik Prijck <[email protected]>
Changes
Updates the sample to use latest Spring Boot and the Okta Spring Boot Starter. This PR updates both the Servlet and Reactive samples. Changes include:
A corresponding PR will be made to the quickstart article prior to merging this change.