Feature/contact shield support #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a libs directory)
… instead of directly accessing AAR-file via libs
…xposure-client (that is based on contactshield)
…xposure-client (that is based on google nearby)
…ses based on hms/gms app-flavor
… 1.0.2 and updating koin would require further refactoring that is not related to ContactShield
…ass file and update ExposureNotificationManager to use platform-specific exposure-client
…ed to version control
…reClient during dependency injection
fix bug where conversation of contact sketch to contact summary is wrong use desugar core library to use Java 8 date API don't show delete ID option in side menu on non GMS device
alexritz
reviewed
Jan 29, 2021
| single { Nearby.getExposureNotificationClient(androidApplication()) } | ||
|
|
||
| single<CommonExposureClient> { | ||
| GoogleExposureClient(androidApplication(), get(), get()) |
There was a problem hiding this comment.
Please provide naming for get() calls
| single { ContactShield.getContactShieldEngine(androidApplication()) } | ||
|
|
||
| single<CommonExposureClient> { | ||
| HuaweiExposureClient(androidApplication(), get(), get(), androidApplication().getSharedPreferences(PREFS_HMS_DEBUG, Context.MODE_PRIVATE)) |
There was a problem hiding this comment.
Please provide naming for get() calls
| @@ -0,0 +1,112 @@ | |||
| package at.roteskreuz.stopcorona.screens.dashboard.epoxy | |||
There was a problem hiding this comment.
Please fix typo in the filename: DashBoardController ->DashboardController
app/src/main/AndroidManifest.xml
Outdated
| @@ -1,6 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest | |||
| xmlns:android="http://schemas.android.com/apk/res/android" | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
Please remove code reformatting commit
# Conflicts: # app/src/main/assets/privacy-and-terms-of-use_de.html # app/src/main/assets/privacy-and-terms-of-use_en.html # app/src/main/assets/privacy_de.html # app/src/main/assets/privacy_en.html
# Conflicts: # app/src/main/java/at/roteskreuz/stopcorona/di/ViewModelModule.kt # app/src/main/java/at/roteskreuz/stopcorona/screens/dashboard/DashboardFragment.kt # app/src/main/java/at/roteskreuz/stopcorona/screens/dashboard/DashboardViewModel.kt # app/src/main/java/at/roteskreuz/stopcorona/screens/mandatory_update/MandatoryUpdateFragment.kt
Hot fix release
minkiapps
force-pushed
the
feature/contact_shield_support
branch
from
2534ceb
to
821a21c
Compare
minkiapps
force-pushed
the
feature/contact_shield_support
branch
from
821a21c
to
84ace7b
Compare
minkiapps
force-pushed
the
feature/contact_shield_support
branch
from
247edaa
to
66edb0f
Compare
# Conflicts: # app/src/main/java/at/roteskreuz/stopcorona/screens/debug/diagnosis_keys/DebugDiagnosisKeysViewModel.kt
# Conflicts: # app/src/main/java/at/roteskreuz/stopcorona/screens/webView/WebViewWithAssetsResourcesFragment.kt
…pendencies and pugins # Conflicts: # app/build.gradle # app/src/main/java/at/roteskreuz/stopcorona/screens/dashboard/DashboardFragment.kt
…dle task app:getDependencies
|
I doubt that this PR will be merged, but if you want to you could provide a PR for the German Corona-Warn-App: https://github.com/corona-warn-app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Integrate HMS Contact Shield, introduce new dimension for HMS integration, introduce wrapper interface for GMS Exposure API and HMS Contact Shield API