Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the type of field
Stack.data
fromVec<U256>
toArrayVec<U256, 1024>
.This optimization was proposed in #448 and is based on the limit of 1024
items for the EVM stack.
Change of a public interface
Stack::data()
returns&[U256]
instead of&Vec<U256>
.NEAR gas usage
There a few tests in
aurora-engine
which fail due to gas usage lower thanexpected:
Issue with
jsontests
This change causes a stack overflow in
evm-tests/jsontests
. Identifyingthe cause of a stack overflow in Rust can be tricky. Therefore, before
trying to get to the bottom of this, it might make sense to evaluate if this
change could/would be merged at all?
Note: It seems like the latest
jsontests
commit suitable for Aurora's EVM forkis
c66b562
.