Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #29 - Stop adding lifetimes to trait generic params #30

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

MrJerB
Copy link
Contributor

@MrJerB MrJerB commented Oct 15, 2023

Fixes #29. I do not have much experience with proc macros so diving into this was my baptism by fire. I hope I've made the change in the correct place! 🤞

Look forward to your review.

@MrJerB MrJerB changed the title Fixes #29: Stop adding lifetimes to trait generic params Fixes #29 - Stop adding lifetimes to trait generic params Oct 15, 2023
Copy link
Owner

@audunhalland audunhalland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@audunhalland audunhalland merged commit 84f3495 into audunhalland:main Oct 15, 2023
2 checks passed
@MrJerB MrJerB deleted the issue-29 branch October 15, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impl expansion incorrectly adding lifetime from method
2 participants