-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace executables with link to demos readme #395
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -8,6 +8,51 @@ requirements: | |||||
url: https://github.com/ros2/demos/blob/iron/composition/README.md | ||||||
checks: | ||||||
- name: The executables in the README and present and work as expected. | ||||||
- name: Demo Nodes (CPP) executables | ||||||
labels: | ||||||
- executable | ||||||
- feature | ||||||
links: | ||||||
- name: Nodes cpp demos | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
url: https://github.com/ros2/demos/blob/iron/demo_nodes_cpp/README.md | ||||||
checks: | ||||||
- name: The executables in the README and present and work as expected. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! I noticed that statement appears (exactly the same) on all the other test cases, I'll go ahead and do the corresponding modification. |
||||||
- name: Demo Nodes Native (CPP) executables | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
labels: | ||||||
- executable | ||||||
- feature | ||||||
links: | ||||||
- name: Nodes cpp native demos | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
url: https://github.com/ros2/demos/blob/iron/demo_nodes_cpp_native/README.md | ||||||
checks: | ||||||
- name: The executables in the README and present and work as expected. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- name: Dummy Map Server executables | ||||||
labels: | ||||||
- executable | ||||||
- feature | ||||||
links: | ||||||
- name: Dummy Map Server | ||||||
url: https://github.com/ros2/demos/blob/iron/dummy_robot/dummy_map_server/README.md#run | ||||||
checks: | ||||||
- name: The executables in the README and present and work as expected. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- name: Dummy Sensors executables | ||||||
labels: | ||||||
- executable | ||||||
- feature | ||||||
links: | ||||||
- name: Dummy Sensors | ||||||
url: https://github.com/ros2/demos/blob/iron/dummy_robot/dummy_sensors/README.md#run | ||||||
checks: | ||||||
- name: The executables in the README and present and work as expected. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- name: Image-tools executables | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
labels: | ||||||
- executable | ||||||
- feature | ||||||
links: | ||||||
- name: Image-tools demos | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
url: https://github.com/ros2/demos/blob/iron/image_tools/README.md#run | ||||||
checks: | ||||||
- name: The executables in the README and present and work as expected. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- name: Intra-process executables | ||||||
labels: | ||||||
- executable | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.