Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace executables with link to demos readme #395

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions requirements/features-executable-from-links.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,51 @@ requirements:
url: https://github.com/ros2/demos/blob/iron/composition/README.md
checks:
- name: The executables in the README and present and work as expected.
- name: Demo Nodes (CPP) executables
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Demo Nodes (CPP) executables
- name: Demo Nodes (C++) executables

labels:
- executable
- feature
links:
- name: Nodes cpp demos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Nodes cpp demos
- name: Demo Nodes C++

url: https://github.com/ros2/demos/blob/iron/demo_nodes_cpp/README.md
checks:
- name: The executables in the README and present and work as expected.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: The executables in the README and present and work as expected.
- name: The executables in the README are present and work as expected.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I noticed that statement appears (exactly the same) on all the other test cases, I'll go ahead and do the corresponding modification.

- name: Demo Nodes Native (CPP) executables
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Demo Nodes Native (CPP) executables
- name: Demo Nodes Native (C++) executables

labels:
- executable
- feature
links:
- name: Nodes cpp native demos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Nodes cpp native demos
- name: Demo Nodes C++ native

url: https://github.com/ros2/demos/blob/iron/demo_nodes_cpp_native/README.md
checks:
- name: The executables in the README and present and work as expected.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: The executables in the README and present and work as expected.
- name: The executables in the README are present and work as expected.

- name: Dummy Map Server executables
labels:
- executable
- feature
links:
- name: Dummy Map Server
url: https://github.com/ros2/demos/blob/iron/dummy_robot/dummy_map_server/README.md#run
checks:
- name: The executables in the README and present and work as expected.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: The executables in the README and present and work as expected.
- name: The executables in the README are present and work as expected.

- name: Dummy Sensors executables
labels:
- executable
- feature
links:
- name: Dummy Sensors
url: https://github.com/ros2/demos/blob/iron/dummy_robot/dummy_sensors/README.md#run
checks:
- name: The executables in the README and present and work as expected.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: The executables in the README and present and work as expected.
- name: The executables in the README are present and work as expected.

- name: Image-tools executables
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Image-tools executables
- name: Image Tools executables

labels:
- executable
- feature
links:
- name: Image-tools demos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Image-tools demos
- name: Image Tools

url: https://github.com/ros2/demos/blob/iron/image_tools/README.md#run
checks:
- name: The executables in the README and present and work as expected.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: The executables in the README and present and work as expected.
- name: The executables in the README are present and work as expected.

- name: Intra-process executables
labels:
- executable
Expand Down
103 changes: 0 additions & 103 deletions requirements/features-executable.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,90 +5,6 @@
# with data from 'executable-features.csv'.

requirements:
- name: Executables in `demo_nodes_cpp`
labels:
- executable
- feature
checks:
- name: Check `talker`
try:
- stdin: ros2 run demo_nodes_cpp talker
- name: Check `listener`
try:
- stdin: ros2 run demo_nodes_cpp listener
- name: Check `listener_best_effort`
try:
- stdin: ros2 run demo_nodes_cpp listener_best_effort
- name: Check `talker_serialized_message`
try:
- stdin: ros2 run demo_nodes_cpp talker_serialized_message
- name: Check `listener_serialized_message`
try:
- stdin: ros2 run demo_nodes_cpp listener_serialized_message
- name: Check `talker_loaned_message`
try:
- stdin: ros2 run demo_nodes_cpp talker_loaned_message
- name: Check `add_two_ints_server`
try:
- stdin: ros2 run demo_nodes_cpp add_two_ints_server
- name: Check `add_two_ints_client`
try:
- stdin: ros2 run demo_nodes_cpp add_two_ints_client
- name: Check `add_two_ints_client_async`
try:
- stdin: ros2 run demo_nodes_cpp add_two_ints_client_async
- name: Check `list_parameters`
try:
- stdin: ros2 run demo_nodes_cpp list_parameters
- name: Check `list_parameters_async`
try:
- stdin: ros2 run demo_nodes_cpp list_parameters_async
- name: Check `set_and_get_parameters`
try:
- stdin: ros2 run demo_nodes_cpp set_and_get_parameters
- name: Check `set_and_get_parameters_async`
try:
- stdin: ros2 run demo_nodes_cpp set_and_get_parameters_async
- name: Check `parameter_events`
try:
- stdin: ros2 run demo_nodes_cpp parameter_events
- name: Check `parameter_events_async`
try:
- stdin: ros2 run demo_nodes_cpp parameter_events_async
- name: Check `parameter_blackboard`
try:
- stdin: ros2 run demo_nodes_cpp parameter_blackboard
- name: Check `even_parameters_node`
try:
- stdin: ros2 run demo_nodes_cpp even_parameters_node
- name: Check `one_off_timer`
try:
- stdin: ros2 run demo_nodes_cpp one_off_timer
- name: Check `reuse_timer`
try:
- stdin: ros2 run demo_nodes_cpp reuse_timer
- name: Check `allocator_tutorial`
try:
- stdin: ros2 run demo_nodes_cpp allocator_tutorial
- name: Executables in `demo_nodes_cpp_native`
labels:
- executable
- feature
checks:
- name: Check `talker`
try:
- stdin: ros2 run demo_nodes_cpp_native talker
- name: Executables in `image_tools`
labels:
- executable
- feature
checks:
- name: Check `cam2image`
try:
- stdin: ros2 run image_tools cam2image
- name: Check `showimage`
try:
- stdin: ros2 run image_tools showimage
- name: Executables in `quality_of_service_demo_cpp`
labels:
- executable
Expand Down Expand Up @@ -416,25 +332,6 @@ requirements:
- name: Check `rttest_plot`
try:
- stdin: ros2 run rttest rttest_plot
- name: Executables in `dummy_map_server`
labels:
- executable
- feature
checks:
- name: Check `dummy_map_server`
try:
- stdin: ros2 run dummy_map_server dummy_map_server
- name: Executables in `dummy_sensors`
labels:
- executable
- feature
checks:
- name: Check `dummy_joint_states`
try:
- stdin: ros2 run dummy_sensors dummy_joint_states
- name: Check `dummy_laser`
try:
- stdin: ros2 run dummy_sensors dummy_laser
- name: Executables in `dummy_robot_bringup`
labels:
- executable
Expand Down