Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improved scan #219

Open
wants to merge 9 commits into
base: testing
Choose a base branch
from
Open

Feature/improved scan #219

wants to merge 9 commits into from

Conversation

audiohacked
Copy link
Owner

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to OpenCorsairLink?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the testing branch (left side). Also you should start your branch off our testing.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Check the commit's or even all commits' message styles matches our requested structure.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Thanks for contributing!

@audiohacked audiohacked force-pushed the feature/improved_scan branch from 8f7c0ee to c581293 Compare December 23, 2019 03:59
@audiohacked audiohacked force-pushed the feature/improved_scan branch from c581293 to b51fd24 Compare May 25, 2020 16:23
@audiohacked audiohacked force-pushed the feature/improved_scan branch from 4f685d8 to fc88731 Compare June 6, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant