Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make generate images function work with parallel in CIFAR files #83

Merged
merged 16 commits into from
Dec 13, 2023

Conversation

kilianFatras
Copy link
Collaborator

@kilianFatras kilianFatras commented Dec 6, 2023

What does this PR do?

  1. Remove unused FLAG variables in cifar experiments.
  2. Make generate_images function work with parallel

Fixes #82 and partially 73

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@kilianFatras kilianFatras changed the title remove unused flag variables in cigar remove unused flag variables in CIFAR files Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c0cfdd) 35.90% compared to head (d964396) 35.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   35.90%   35.90%           
=======================================
  Files          67       67           
  Lines        7419     7419           
=======================================
  Hits         2664     2664           
  Misses       4755     4755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kilianFatras kilianFatras changed the title remove unused flag variables in CIFAR files make generate images function work with parallel in CIFAR files Dec 6, 2023
@kilianFatras
Copy link
Collaborator Author

-- DO NOT MERGE --

After two tests, the above fix does not seem to perform as well as the main branch. I got an FID of 4.9 for the two tests while it should be 3.6. For now, I consider the parallel training not fixed.

@kilianFatras kilianFatras marked this pull request as draft December 9, 2023 16:16
@kilianFatras kilianFatras marked this pull request as ready for review December 13, 2023 20:32
@kilianFatras kilianFatras merged commit b29d418 into main Dec 13, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel problem
2 participants