Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update single-cell notebook with trajectories from a given cell #64

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

kilianFatras
Copy link
Collaborator

What does this PR do?

This PR adds illustration examples to the single-cell notebooks where we show the trajectory difference between SF2M and SBCFM from the same cell. SB-CFM only produces one trajectory (by its deterministic nature) contrary to SF2M which produces several outputs as it models a stochastic process.

It is a novel feature.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dbeeb75) 34.23% compared to head (64aed61) 34.23%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   34.23%   34.23%           
=======================================
  Files          55       55           
  Lines        6268     6268           
=======================================
  Hits         2146     2146           
  Misses       4122     4122           
Files Coverage Δ
runner/src/datamodules/distribution_datamodule.py 44.82% <100.00%> (ø)
runner/src/eval.py 81.08% <ø> (ø)
runner/src/train.py 92.59% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@atong01 atong01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atong01 atong01 merged commit 1c44a6a into main Oct 18, 2023
16 checks passed
@atong01 atong01 deleted the single_cell branch October 18, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants