Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#171380690 Create the client readme file #8

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

muchristian
Copy link
Collaborator

What does this PR ​ do​ ?
Create the client readme file by needed information

Description of Task to be completed?

  • Installation and run commands
  • Description
  • Dependencies
  • Tests setup and executionTests setup and execution
  • add badges
   Code Climate maintainability badge
   Code Climate code coverage badge 
   Travis status badge

How should this be manually tested?
N/A

Any background context you want to provide?
N/A

What are the relevant pivotal tracker stories?
#171380690

Screenshots
N/A

Questions:
N/A

Copy link
Collaborator

@descholar-ceo descholar-ceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work on the suggested changes

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@muchristian muchristian force-pushed the ch-create-the-client-readme-file-171380690 branch from 7044779 to f47fb6f Compare May 22, 2020 11:48
@descholar-ceo descholar-ceo self-requested a review May 22, 2020 16:20
Copy link
Collaborator

@descholar-ceo descholar-ceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to suggest you follow best practices of naming PRs, your PR title doesn't follow that convention. Use this reference of Andela best practices

README.md Outdated Show resolved Hide resolved
@muchristian muchristian changed the title chore: Create the client readme file #171380690 Create the client readme file May 25, 2020
@muchristian muchristian force-pushed the ch-create-the-client-readme-file-171380690 branch from f47fb6f to fb1070a Compare May 25, 2020 21:45
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@muchristian muchristian force-pushed the ch-create-the-client-readme-file-171380690 branch from fb1070a to a75d4c5 Compare May 26, 2020 12:01
added information
- Installation and run commands
- Description
- Dependencies
- Tests setup and executionTests setup and execution
- add badges ( code climate maintainability, code climate code coverage, travis status)
@muchristian muchristian force-pushed the ch-create-the-client-readme-file-171380690 branch from a75d4c5 to 1c8c480 Compare May 26, 2020 14:23
@Ugizwenayo-Divine Ugizwenayo-Divine temporarily deployed to stackup-barefoot May 27, 2020 07:59 Inactive
@kipropbrian
Copy link
Collaborator

This is already done in the previous PR.

@muchristian muchristian added WIP Work In Progress Ready for review Ready for peer review and removed Ready for review Ready for peer review WIP Work In Progress labels May 27, 2020
@muchristian muchristian added TTL Review When it is ready for Team Lead review and removed Ready for review Ready for peer review labels May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rebase TTL Review When it is ready for Team Lead review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants