-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#171380695 user login #12
base: develop
Are you sure you want to change the base?
Conversation
7cc497a
to
1246b48
Compare
1246b48
to
283ec6a
Compare
283ec6a
to
832bd81
Compare
832bd81
to
68f9272
Compare
68f9272
to
5db0772
Compare
5db0772
to
329d823
Compare
329d823
to
d28d35e
Compare
d28d35e
to
0cdc6f0
Compare
0cdc6f0
to
0375b86
Compare
0375b86
to
bfc43db
Compare
bfc43db
to
cf18de0
Compare
src/helpers/userLogin.js
Outdated
|
||
const login = async (user) => { | ||
let result = ''; | ||
const url = 'https://bft-nmd-stag.herokuapp.com/api/auth/login'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this URL to the .env file as it is a variable that is better handled there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've implemented this feedback
src/actions/loginActions.js
Outdated
const loginError = (data) => ({ type: LOGIN_HANDLE, payload: data }); | ||
|
||
const handleLogin = (credentials) => async (dispatch) => { | ||
let output = ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to declare this variable here. Delete this line and on line 15 do const output = token ...
src/components/forms/InputField.js
Outdated
}, | ||
}); | ||
|
||
const InputField = (props) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could destructure props directly here instead of line 22.
const InputField = ({ handleLoginChange, name }) => {}
there should be a login button to click because for me it's there |
Could you share a screenshot? I even tried inspecting the HTML and I saw only the main div with an id of |
cf18de0
to
02dd16d
Compare
02dd16d
to
7f8420a
Compare
7f8420a
to
2298adb
Compare
2298adb
to
0121cf8
Compare
0121cf8
to
89a1c80
Compare
89a1c80
to
5120817
Compare
5120817
to
cb7fcf4
Compare
cb7fcf4
to
14e3e20
Compare
14e3e20
to
5a79627
Compare
5a79627
to
ff1e1b8
Compare
3852505
to
8fa2bdc
Compare
8fa2bdc
to
71a0151
Compare
- user should be able to login - user should receive appropriate error message [Finishes #171380695]
71a0151
to
547377f
Compare
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
In your terminal, run
git clone https://github.com/Stackup-Rwanda/stackup2-barefoot-frontend.git
to clone this repoRun `git fetch origin ft-user-login-171380695
Run
git checkout ft-user-login-171380695
to switch to the fetched branch aboveRun
yarn install
to install all dependenciesStart the development server by running
yarn dev
.The server should launch the app in your default browser at
localhost:{{PORT}}
Click the login button, you will see the login form
try to login with the user in database
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#171380695