feat-wishlist-management #53

Calebgisa72 · 2024-07-04T18:12:48Z

What does this PR do?

This PR enhances the buyer experience by implementing comprehensive management features for the wishlist functionality.

Description of Task Completed

Tasks completed in this PR:

Designed and integrated UI components for managing the Buyer wishlist.
Implemented state management using Redux to maintain wishlist state across sessions.
Added functionality to display wishlist icons on products when users are logged in, enhancing user interaction.
Ensured seamless integration with backend APIs for wishlist operations, including adding, removing, and updating wishlist items.
Conducted unit tests to verify functionality and maintain code quality, ensuring robust performance under various scenarios.

How should this be manually tested?

Ensure You have backend service running and set VITE_APP_API_URL in your .env file.
Clone this repository and navigate to the project director

git clone -b ft-register https://github.com/atlp-rwanda/knights-ecomm-fe.git cd knights-ecomm-fe git checkout ft-landing-page npm i npm run dev

Screenshots

netlify · 2024-07-04T18:13:03Z

✅ Deploy Preview for knights-fecommerce ready!

Name	Link
🔨 Latest commit	`b8a24d5`
🔍 Latest deploy log	https://app.netlify.com/sites/knights-fecommerce/deploys/668910033ae2670008c04104
😎 Deploy Preview	https://deploy-preview-53--knights-fecommerce.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-07-04T18:13:17Z

✅ Deploy Preview for knight-fe ready!

Name	Link
🔨 Latest commit	`b8a24d5`
🔍 Latest deploy log	https://app.netlify.com/sites/knight-fe/deploys/66891003c5b9b400085366ff
😎 Deploy Preview	https://deploy-preview-53--knight-fe.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls · 2024-07-04T18:15:49Z

coverage: 87.127% (-0.6%) from 87.754%
when pulling a59f02e on ft-wishlist-management
into 86a5319 on develop.

faid-terence · 2024-07-05T06:47:20Z

@Calebgisa72 Rebase with develop to resolve the conflicts and increase the coverage as well !

coveralls · 2024-07-05T09:25:05Z

coverage: 87.539% (-0.4%) from 87.967%
when pulling 627a390 on ft-wishlist-management
into b6fa239 on develop.

coveralls · 2024-07-05T10:56:43Z

coverage: 88.2% (+0.2%) from 87.967%
when pulling 7f7d8d1 on ft-wishlist-management
into b6fa239 on develop.

coveralls · 2024-07-05T11:05:49Z

coverage: 88.337% (+0.4%) from 87.967%
when pulling 5b8f8cb on ft-wishlist-management
into b6fa239 on develop.

coveralls · 2024-07-05T11:06:48Z

coverage: 88.337% (+0.4%) from 87.967%
when pulling 5b8f8cb on ft-wishlist-management
into b6fa239 on develop.

aimedivin

@Calebgisa72 Please remove console logs

coveralls · 2024-07-05T13:51:45Z

coverage: 88.332% (+0.4%) from 87.967%
when pulling 38df394 on ft-wishlist-management
into b6fa239 on develop.

coveralls · 2024-07-05T13:51:55Z

coverage: 88.332% (+0.4%) from 87.967%
when pulling 38df394 on ft-wishlist-management
into b6fa239 on develop.

faid-terence · 2024-07-06T06:46:39Z

Hey @Calebgisa72
Please rebase with develop and resolve the conflicts !

faid-terence

@Calebgisa72
Work on these feedbacks and re-request for reviews from me after they are applied !

faid-terence · 2024-07-06T06:48:36Z

src/pages/WishlistPage/WishlistPage.tsx

@Calebgisa72
Instead of console.error('Failed to fetch wishlist', error)
Can we use toast.error and display the error to the user
To enhnace a good user experience !

faid-terence · 2024-07-06T06:50:38Z

src/utils/wishlistFunctions/addProduct.ts

@Calebgisa72
Please avoid using any for Dispatch
You can use AppDispatch()

coveralls · 2024-07-06T08:36:22Z

coverage: 88.231% (+0.1%) from 88.103%
when pulling f32bf6f on ft-wishlist-management
into e5468d2 on develop.

coveralls · 2024-07-06T08:41:22Z

coverage: 88.103%. remained the same
when pulling c510169 on ft-wishlist-management
into e5468d2 on develop.

coveralls · 2024-07-06T08:41:27Z

coverage: 88.069% (-0.03%) from 88.103%
when pulling c510169 on ft-wishlist-management
into e5468d2 on develop.

coveralls · 2024-07-06T09:11:27Z

coverage: 88.354% (+0.3%) from 88.103%
when pulling 8f36613 on ft-wishlist-management
into e5468d2 on develop.

coveralls · 2024-07-06T09:19:55Z

coverage: 88.362% (+0.3%) from 88.103%
when pulling 802af9d on ft-wishlist-management
into e5468d2 on develop.

coveralls · 2024-07-06T09:20:11Z

coverage: 88.362% (+0.3%) from 88.103%
when pulling 802af9d on ft-wishlist-management
into e5468d2 on develop.

Enable to delete a product

coveralls · 2024-07-06T09:38:39Z

coverage: 88.349% (+0.2%) from 88.103%
when pulling b8a24d5 on ft-wishlist-management
into e5468d2 on develop.

faid-terence

Good Job @Calebgisa72
PR Approved !

Calebgisa72 linked an issue Jul 4, 2024 that may be closed by this pull request

Wishlist management #45

Closed

Calebgisa72 added frontend Related to frontend in progress task has already been started labels Jul 4, 2024

Calebgisa72 force-pushed the ft-wishlist-management branch from a59f02e to 627a390 Compare July 5, 2024 09:22

Calebgisa72 force-pushed the ft-wishlist-management branch from 627a390 to 7f7d8d1 Compare July 5, 2024 10:54

Calebgisa72 force-pushed the ft-wishlist-management branch from 7f7d8d1 to 5b8f8cb Compare July 5, 2024 11:03

Calebgisa72 requested review from aimedivin, maxCastro1, mukunzidd, MC-Knight, GSinseswa721, faid-terence, UwicyezaG and Ndevu12 July 5, 2024 11:04

Calebgisa72 requested a review from elijahladdie July 5, 2024 11:06

Calebgisa72 added Ready for reviews and removed in progress task has already been started labels Jul 5, 2024

aimedivin approved these changes Jul 5, 2024

View reviewed changes

Calebgisa72 force-pushed the ft-wishlist-management branch from 5b8f8cb to 38df394 Compare July 5, 2024 13:49

faid-terence requested changes Jul 6, 2024

View reviewed changes

faid-terence assigned Calebgisa72 Jul 6, 2024

faid-terence added this to the Cart, Wishlist and Checkout milestone Jul 6, 2024

faid-terence added the Highest Priority label Jul 6, 2024

GSinseswa721 approved these changes Jul 6, 2024

View reviewed changes

Calebgisa72 force-pushed the ft-wishlist-management branch from 38df394 to f32bf6f Compare July 6, 2024 08:33

Calebgisa72 force-pushed the ft-wishlist-management branch from f32bf6f to c510169 Compare July 6, 2024 08:38

maxCastro1 approved these changes Jul 6, 2024

View reviewed changes

Calebgisa72 force-pushed the ft-wishlist-management branch from c510169 to 8f36613 Compare July 6, 2024 09:08

Calebgisa72 force-pushed the ft-wishlist-management branch from 8f36613 to 802af9d Compare July 6, 2024 09:17

Calebgisa72 requested a review from faid-terence July 6, 2024 09:17

Merge pull request #36 from atlp-rwanda/ft-delete-product

b8a24d5

Enable to delete a product

Calebgisa72 force-pushed the ft-wishlist-management branch from 802af9d to b8a24d5 Compare July 6, 2024 09:36

faid-terence approved these changes Jul 6, 2024

View reviewed changes

faid-terence merged commit 7ef982f into develop Jul 6, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat-wishlist-management #53

feat-wishlist-management #53

Calebgisa72 commented Jul 4, 2024 •

edited

Loading

netlify bot commented Jul 4, 2024 •

edited

Loading

netlify bot commented Jul 4, 2024 •

edited

Loading

coveralls commented Jul 4, 2024

faid-terence commented Jul 5, 2024

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

aimedivin left a comment

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

faid-terence commented Jul 6, 2024

faid-terence left a comment

faid-terence Jul 6, 2024

faid-terence Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

faid-terence left a comment

feat-wishlist-management #53

feat-wishlist-management #53

Conversation

Calebgisa72 commented Jul 4, 2024 • edited Loading

netlify bot commented Jul 4, 2024 • edited Loading

✅ Deploy Preview for knights-fecommerce ready!

netlify bot commented Jul 4, 2024 • edited Loading

✅ Deploy Preview for knight-fe ready!

coveralls commented Jul 4, 2024

faid-terence commented Jul 5, 2024

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

aimedivin left a comment

Choose a reason for hiding this comment

coveralls commented Jul 5, 2024

coveralls commented Jul 5, 2024

faid-terence commented Jul 6, 2024

faid-terence left a comment

Choose a reason for hiding this comment

faid-terence Jul 6, 2024

Choose a reason for hiding this comment

faid-terence Jul 6, 2024

Choose a reason for hiding this comment

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

coveralls commented Jul 6, 2024

faid-terence left a comment

Choose a reason for hiding this comment

Calebgisa72 commented Jul 4, 2024 •

edited

Loading

netlify bot commented Jul 4, 2024 •

edited

Loading

netlify bot commented Jul 4, 2024 •

edited

Loading