Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#187419017 Users should be able to search #33

Merged
merged 1 commit into from
Jul 8, 2024
Merged

#187419017 Users should be able to search #33

merged 1 commit into from
Jul 8, 2024

Conversation

kwizera-bonheur25
Copy link
Collaborator

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

  • Users should be able to search
  • A buyer needs to have a way to search for a product t. by name, by price range, by category, etc it can also be a combination of two or more with AND operation.

What are the relevant pivotal tracker/Trello stories?

#187419017

@vercel Vercel
Copy link

vercel bot commented Jul 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackers-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 10:57am

hound[bot]
hound bot reviewed Jul 3, 2024
View reviewed changes
src/@types/SearchType.ts
@@ -0,0 +1,15 @@
import { DynamicData } from './DynamicData';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

@kwizera-bonheur25
feat(search): Implement product search
3b35972 
-
A buyer needs to have a way to search for a product
t. by name, by price range, by category, etc it can also be a combination of two or more with AND operation

- [Delivers #187419017]
hound[bot]
hound bot reviewed Jul 8, 2024
View reviewed changes
src/pages/LandingProduct.tsx
@@ -1,3 +1,4 @@
import { motion } from 'framer-motion';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

src/pages/ProductsPage.tsx
@@ -1,3 +1,4 @@
import { motion } from 'framer-motion';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

src/redux/features/SearchSlice.ts
@@ -0,0 +1,61 @@
/* eslint-disable @typescript-eslint/no-explicit-any */
import { createAsyncThunk, createSlice, PayloadAction } from '@reduxjs/toolkit';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

@leandreAlly leandreAlly merged commit dc83975 into develop Jul 8, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound left review comments

@leandreAlly leandreAlly leandreAlly approved these changes

@cyusasnave cyusasnave cyusasnave approved these changes

@Tuyisenge2 Tuyisenge2 Tuyisenge2 approved these changes

@denislohan denislohan Awaiting requested review from denislohan

Assignees
No one assigned
Labels
Read for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kwizera-bonheur25 @leandreAlly @cyusasnave @Tuyisenge2