Feature Admin update role 187584923 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndahimana154
requested review from
AimePazzo,
ProgrammerDATCH and
MANISHIMWESalton
key-joshua
reviewed
May 29, 2024
key-joshua
reviewed
May 29, 2024
|
Please resolve the conflicts |
key-joshua
reviewed
May 29, 2024
…-rwanda/e-commerce-ninjas-bn into admin-update-role-187584923
…-rwanda/e-commerce-ninjas-bn into admin-update-role-187584923
key-joshua
reviewed
May 30, 2024
key-joshua
reviewed
May 30, 2024
key-joshua
reviewed
May 30, 2024
src/routes/userRouter.ts
Outdated
| const router: Router = Router() | ||
|
|
||
| router.put("/admin-update-user-status/:id", validation(statusSchema), isUserExist, userControllers.updateUserStatus); | ||
| router.put("/admin-update-role/:id",validation(updateUserRoleSchema),validateUpdateUserRole, userControllers.updateUserRole); |
There was a problem hiding this comment.
What the use this middleware validateUpdateUserRole ?
There was a problem hiding this comment.
At first i was using it checking if the user exists but i removed it, as there is the one made for that.
key-joshua
reviewed
May 30, 2024
key-joshua
reviewed
May 30, 2024
key-joshua
reviewed
May 30, 2024
key-joshua
reviewed
May 30, 2024
key-joshua
reviewed
May 30, 2024
…-rwanda/e-commerce-ninjas-bn into admin-update-role-187584923
…-rwanda/e-commerce-ninjas-bn into admin-update-role-187584923
…-rwanda/e-commerce-ninjas-bn into admin-update-role-187584923
…-rwanda/e-commerce-ninjas-bn into admin-update-role-187584923
…-rwanda/e-commerce-ninjas-bn into admin-update-role-187584923
…-rwanda/e-commerce-ninjas-bn into admin-update-role-187584923
…-rwanda/e-commerce-ninjas-bn into admin-update-role-187584923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished to allow the admin to change the role of any User,
The roles are ['Admin','Seller','Buyer'] only.
The remainig task on this feature is to protect the route. and checking if the acting user is Admin truly.