Merge pull request #18 from atlp-rwanda/bg-bugs-fix

bg(bug fix):fixing bugs

.codeclimate.yml

@@ -8,5 +8,6 @@ checks:
     eslint:
       enabled: true
 exclude_patterns:
+  - "**/src/__test__/*"
   - "**/package-lock.json/"
   - "**/.env/*"

.eslintrc.json

@@ -1,74 +1,81 @@
+
 {
   "root": true,
-  "parser": "@typescript-eslint/parser",
-  "extends": [
-    "airbnb-base",
-    "plugin:@typescript-eslint/recommended",
-    "plugin:prettier/recommended"
-  ],
-  "settings": {
-    "import/resolver": {
-      "node": {
-        "extensions": [".js", ".ts"]
-      }
+"parser": "@typescript-eslint/parser",
+"extends": [
+  "airbnb-base",
+  "plugin:@typescript-eslint/recommended",
+  "plugin:prettier/recommended"
+],
+"settings": {
+  "import/resolver": {
+    "node": {
+      "extensions": [".js", ".ts"]
     }
-  },
-  "env": {
-    "node": true,
-    "es6": true,
-    "mocha": true
-  },
-  "rules": {
-    "one-var": 0,
-    "one-var-declaration-per-line": 0,
-    "new-cap": 0,
-    "consistent-return": 0,
-    "no-param-reassign": 0,
-    "comma-dangle": 0,
-    "curly": ["error", "multi-line"],
-    "import/no-unresolved": [2, { "commonjs": true }],
-    "no-shadow": ["error", { "allow": ["req", "res", "err"] }],
-    "valid-jsdoc": [
-      "error",
-      {
-        "requireReturn": true,
-        "requireReturnType": true,
-        "requireParamDescription": false,
-        "requireReturnDescription": true
-      }
-    ],
-    "import/extensions": [
-      "error",
-      "ignorePackages",
-      {
-        "": "never",
-        "js": "never",
-        "ts": "never"
-      }
-   ],
-    "import/prefer-default-export": 0,
-    "require-jsdoc": [
-      "error",
-      {
-        "require": {
-          "FunctionDeclaration": true,
-          "MethodDefinition": true,
-          "ClassDeclaration": true
-        }
-      }
-    ]
-  },
-  "parserOptions": {
-    "ecmaVersion": 6,
-    "sourceType": "module",
-    "project": "./tsconfig.json"
-  },
-  "plugins": ["prettier", "node", "mocha", "jsdoc", "@typescript-eslint"],
-  "overrides": [
+  }
+},
+"env": {
+  "node": true,
+  "es6": true,
+  "mocha": true
+},
+"rules": {
+  "one-var": 0,
+  "camelcase": ["error", { "properties": "always", "allow": ["_"] }],
+  "@typescript-eslint/no-explicit-any": 0,
+  "no-console": 0,
+  "one-var-declaration-per-line": 0,
+  "new-cap": 0,
+  "consistent-return": 0,
+  "no-param-reassign": 0,
+  "comma-dangle": 0,
+  "curly": ["error", "multi-line"],
+  "import/no-unresolved": [2, { "commonjs": true }],
+  "no-shadow": ["error", { "allow": ["req", "res", "err"] }],
+  "valid-jsdoc": [
+    "error",
+    {
+      "requireReturn": true,
+      "requireReturnType": true,
+      "requireParamDescription": false,
+      "requireReturnDescription": true
+    }
+  ],
+  "import/extensions": [
+    "error",
+    "ignorePackages",
     {
-      "extends": ["plugin:@typescript-eslint/disable-type-checked"],
-      "files": ["*.js", "*.ts"]
+      "": "never",
+      "js": "never",
+      "ts": "never"
     }
-  ]
+  ],
+  "import/prefer-default-export": 0,
+  "require-jsdoc": 0
+},
+"parserOptions": {
+  "ecmaVersion": 6,
+  "sourceType": "module",
+  "project": "./tsconfig.json"
+},
+"plugins": ["prettier", "node", "mocha", "jsdoc", "@typescript-eslint"],
+"overrides": [
+  {
+    "files": ["**/*.test.ts", "**/*.test.js", "**/*.spec.ts", "**/*.spec.js"],
+    "rules": {
+      "no-unused-expressions": 0
+    }
+  },
+  {
+    "extends": ["plugin:@typescript-eslint/disable-type-checked"],
+    "files": ["*.js", "*.ts"]
+  }
+]
 }
 
+
+
+
+
+
+

.prettierrc

@@ -1,5 +1,10 @@
 {
     "semi": true,
     "singleQuote": false,
-    "trailingComma": "none"
-}
+    "trailingComma": "none",
+    "endOfLine": "auto",
+    "curly": "all",
+    "eqeqeq": "always",
+    "no-trailing-spaces": "error"
+  }
+

README.md

@@ -1,11 +1,14 @@
 ### champs-ec-be
 
-[![Coverage Status](https://coveralls.io/repos/github/atlp-rwanda/champs-ec-be/badge.svg?branch=development)](https://coveralls.io/github/atlp-rwanda/champs-ec-be?branch=development)
-![Code Climate coverage](https://img.shields.io/codeclimate/coverage/atlp-rwanda/champs-ec-be)
+[![Reviewed by Hound](https://img.shields.io/badge/Reviewed_by-Hound-8E64B0.svg)](https://houndci.com)
+[![CircleCI](https://dl.circleci.com/status-badge/img/gh/atlp-rwanda/champs-ec-be/tree/development.svg?style=svg)](https://dl.circleci.com/status-badge/redirect/gh/atlp-rwanda/champs-ec-be/tree/development)
+[![Coverage Status](https://coveralls.io/repos/github/atlp-rwanda/champs-ec-be/badge.svg)](https://coveralls.io/github/atlp-rwanda/champs-ec-be)
 [![Maintainability](https://api.codeclimate.com/v1/badges/44cd8dee96aeb01f2dd0/maintainability)](https://codeclimate.com/github/atlp-rwanda/champs-ec-be/maintainability)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/44cd8dee96aeb01f2dd0/test_coverage)](https://codeclimate.com/github/atlp-rwanda/champs-ec-be/test_coverage)
+
 ![NodeJS](https://img.shields.io/badge/node.js-6DA55F?style=for-the-badge&logo=node.js&logoColor=white) ![Express.js](https://img.shields.io/badge/express.js-%23404d59.svg?style=for-the-badge&logo=express&logoColor=%2361DAFB) ![CircleCI](https://img.shields.io/badge/circle%20ci-%23161616.svg?style=for-the-badge&logo=circleci&logoColor=white)
 
+[![HoundCI](https://img.shields.io/badge/style--blue.svg?label=HoundCI&logo=eslint&style=flat)](https://houndci.com)
+
 # How to use the project
 
 ## How to use the project online

babel.config.js

@@ -1,6 +1,6 @@
 module.exports = {
   presets: [
     ["@babel/preset-env", { targets: { node: "current" } }],
-    "@babel/preset-typescript",
-  ],
+    "@babel/preset-typescript"
+  ]
 };