-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump oas3 #138
Bump oas3 #138
Conversation
🦋 Changeset detectedLatest commit: 016259d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
changeset fix github action bump typescript version
9946334
to
016259d
Compare
@@ -10,7 +10,7 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
node-version: [14.x, 16.x] | |||
node-version: [16.x, 18.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include 20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctx.body = openapiUI({
title: doc.info ? doc.info.title : 'openapi UI',
url: config.endpoint,
swaggerUiBundleBasePath: config.swaggerUiBundleBasePath
});
I think we could cache the result of openapiUI()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Store coerced values
ctx.oas = {
request: {
query: validRequest.query,
params: validRequest.path,
header: validRequest.header,
},
operationId: validRequest.operationId
};
It seems that we're missing describing ctx.oas
in the readme file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @lukiano +++++ I will address those in a following up PR. |
Watch out for warnings like this when bumping.