Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump oas3 #138

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Bump oas3 #138

merged 1 commit into from
Oct 3, 2023

Conversation

supertong
Copy link
Collaborator

@supertong supertong commented Sep 27, 2023

Watch out for warnings like this when bumping.
image

@supertong supertong requested a review from ngot September 27, 2023 04:45
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: 016259d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
koa-oas3 Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@atlassian-cla-bot
Copy link

atlassian-cla-bot bot commented Sep 27, 2023

Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution.
If your email is listed below, please ensure that you sign the CLA with the same email address.

The following users still need to sign our CLA:
❌atlastong

Already signed the CLA? To re-check, try refreshing the page.

changeset

fix github action

bump typescript version
@supertong supertong merged commit 6905eee into atlassian:master Oct 3, 2023
3 checks passed
@supertong supertong deleted the bump-oas3 branch October 3, 2023 03:24
@@ -10,7 +10,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [16.x, 18.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include 20?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctx.body = openapiUI({
        title: doc.info ? doc.info.title : 'openapi UI',
        url: config.endpoint,
        swaggerUiBundleBasePath: config.swaggerUiBundleBasePath
      });

I think we could cache the result of openapiUI()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Store coerced values
      ctx.oas = {
        request: {
          query: validRequest.query,
          params: validRequest.path,
          header: validRequest.header,
        },
        operationId: validRequest.operationId
      };

It seems that we're missing describing ctx.oas in the readme file.

Copy link
Contributor

@lukiano lukiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supertong
Copy link
Collaborator Author

Thanks @lukiano +++++ I will address those in a following up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants