send batches concurrently in each flush and compress payload #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,8 @@ | |||
| package data | |||
|
|
|||
| import ( | |||
| "bytes" | |||
| "compress/gzip" | |||
There was a problem hiding this comment.
I think this will be fine for now, but we will need to look at adopting lz4 compression to help improve performance.
There was a problem hiding this comment.
idk if there's choice for now as the OTLP doc is quite confusing, specification here says it only need to support gzip to meet the minimal requirement for a OTLP server
waynewu411
approved these changes
Aug 7, 2024
irisgve
reviewed
Aug 7, 2024
| atomic.AddUint64(&bd.seriesSent, uint64(b.lenMetrics())) | ||
| } | ||
| func(g group) { | ||
| eg.Go(func() error { |
There was a problem hiding this comment.
Cool this means async sends? Do we have any retries in the otlp backend?
There was a problem hiding this comment.
yeah retry is in the postMetrics
irisgve
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send batches concurrently in each flush and compress payload.
This should shorten process time for each flush and also reduce the size of payload.