Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve schema validation factory #638

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve schema validation factory #638

wants to merge 4 commits into from

Conversation

gnawf
Copy link
Collaborator

@gnawf gnawf commented Nov 27, 2024

No description provided.

@gnawf gnawf marked this pull request as draft November 27, 2024 22:54
Copy link

github-actions bot commented Nov 27, 2024

Test Results

  134 files  +1  134 suites  +1   56s ⏱️ -1s
  999 tests +1  934 ✅ +1  65 💤 ±0  0 ❌ ±0 
1 007 runs  +1  942 ✅ +1  65 💤 ±0  0 ❌ ±0 

Results for commit a19a800. ± Comparison against base commit bc72914.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
graphql.nadel.validation.NadelVirtualTypeValidationTest ‑ can reference ()
graphql.nadel.validation.NadelValidationDefinitionsTest ‑ do not use parse definitions functions in validation()
graphql.nadel.validation.NadelVirtualTypeValidationTest ‑ can use original field output type in virtual type()

♻️ This comment has been updated with latest results.

@gnawf gnawf force-pushed the custom-hydration-directive-2 branch from b0cf2ca to a337f89 Compare December 2, 2024 00:04
@gnawf gnawf changed the base branch from custom-hydration-directive-2 to master December 2, 2024 03:37
@gnawf gnawf marked this pull request as ready for review December 2, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant