Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make yarn installs immutable #1733

Closed
wants to merge 2 commits into from

Conversation

kylorhall-atlassian
Copy link
Collaborator

@kylorhall-atlassian kylorhall-atlassian commented Oct 23, 2024

What is this change?

Context: https://github.com/atlassian-labs/compiled/pull/1732/files#r1813527167, I've noticed a few times I get yarn.lock diffs staged when they should probably be committed.

Why are we making this change?

To make sure we don't leave out important changes.


PR checklist

Don't delete me! 🤣

  • Testing…this should fail without yarn.lock changes as master is currently broken.

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: c261eb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for compiled-css-in-js canceled.

Name Link
🔨 Latest commit c261eb0
🔍 Latest deploy log https://app.netlify.com/sites/compiled-css-in-js/deploys/67196179c4272e000869183f

@@ -35,7 +35,7 @@ jobs:
${{ runner.os }}-yarn-

- name: Install packages
run: yarn
run: yarn --frozen-lockfile
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern with having this in all the files is the devex could be a bit annoying, but CI runs very quickly here…so I expect it's not worth intentionally omitting it from other workflows.

@kylorhall-atlassian kylorhall-atlassian marked this pull request as draft October 23, 2024 20:54
@kylorhall-atlassian
Copy link
Collaborator Author

Nevermind, I'm confused a bit—this doesn't even seem to work in full like I expected; in Yarn v2+ this works, and then scripts/postinstall.sh confuses me too…I think it's a good idea, but I forget how to execute it. I'll ignore for now.

@kylorhall-atlassian kylorhall-atlassian deleted the kylorhall/immutable-yarn branch October 23, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant