-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make yarn installs immutable #1733
Conversation
|
✅ Deploy Preview for compiled-css-in-js canceled.
|
@@ -35,7 +35,7 @@ jobs: | |||
${{ runner.os }}-yarn- | |||
|
|||
- name: Install packages | |||
run: yarn | |||
run: yarn --frozen-lockfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only concern with having this in all the files is the devex could be a bit annoying, but CI runs very quickly here…so I expect it's not worth intentionally omitting it from other workflows.
Nevermind, I'm confused a bit—this doesn't even seem to work in full like I expected; in Yarn v2+ this works, and then |
What is this change?
Context: https://github.com/atlassian-labs/compiled/pull/1732/files#r1813527167, I've noticed a few times I get
yarn.lock
diffs staged when they should probably be committed.Why are we making this change?
To make sure we don't leave out important changes.
PR checklist
Don't delete me! 🤣
yarn.lock
changes as master is currently broken.