Continue to support Python 2 #1453
Conversation
|
@madscientist how about to adjust black ? :) |
Avoid Python 3-only capabilities: - Remove f-strings (jira.py, confluence.py) - Remove type specifications (bitbucket) - Remove trailing commas (bitbucket)
madscientist
force-pushed
the
pds-py2
branch
from
cb5e478
to
c5f02a3
Compare
|
Hrm, I fixed the black warnings but there's some kind of GPG key issue with the Ubuntu PPA that's now causing test failures. |
|
python2 has been deprecated 4 years ago, I don't see a good reason to keep library backwards compatibility with python2.x |
|
Well, that's up to the project of course. But currently the setup for this module says it supports Python 2, but it fails. This relatively small patch continues to support Python 2. If the project decides that they no longer want to support Python 2, then they need to modify setup.py to stop saying it does. Regardless of that, the failures in the online tests above are due to some kind of PPA key failure which has nothing to do with Python 2, and needs to be addressed before I can rerun my tests to verify the patch. Cheers! |
|
@madscientist let's continue to support python2 |
|
How about dropping Python 2 support in this library starting with the next major release (4.x)? I understand that some older codebases are still using Python 2.7, but continuing to support a deprecated version of Python (which has been unsupported for four years now) will inevitably lead to challenges for both maintainers and users of the library. While adjusting obvious elements like f-string syntax is straightforward and makes sense to me, we shouldn't hold back from utilizing the latest improvements introduced in Python 3.x. If we aim to remain fully compatible with Python 2.7, we would also need to modify code that uses the latest features of Python. |
|
I looked around to try to find a way to re-run the checks in the hopes that whatever the certificate error was, has been resolved, but I don't seem to have permissions to do it (google tells me how to do it but I don't see that option). Maybe someone else can re-run for me. |
|
@madscientist thanks @gkowalc let's formalize it and prepare an announce for drop py 2.7 |
|
Sounds good. I recommend you arrange to bump the major version when you drop P2 support. Thanks for pulling! |
|
indeed, let's agree about that. |
Avoid Python 3-only capabilities: