Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract $socket from constructor property promotion #2

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Extract $socket from constructor property promotion #2

merged 2 commits into from
Oct 24, 2023

Conversation

pavog
Copy link
Member

@pavog pavog commented Oct 24, 2023

Extract $socket from constructor property promotion and make it a normal class member with type resource instead of resource|Socket.
This will make it clear that $socket is always of type resource.

matthi4s
matthi4s requested changes Oct 24, 2023
View reviewed changes
src/Communication/Socket/Socket.php Outdated Show resolved Hide resolved
@pavog @matthi4s
add type to $socket
c626494 
Co-authored-by: Matthias Neid <[email protected]>
@pavog pavog requested a review from matthi4s October 24, 2023 11:28
@matthi4s matthi4s merged commit 9f34ecc into aternosorg:master Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthi4s matthi4s matthi4s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavog @matthi4s