Skip to content

Commit

Permalink
specify php version, added tests workflow, fixed tests on php 8.1
Browse files Browse the repository at this point in the history
  • Loading branch information
matthi4s committed Oct 23, 2023
1 parent 75194f7 commit a0e5295
Show file tree
Hide file tree
Showing 4 changed files with 53 additions and 4 deletions.
45 changes: 45 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: Tests

on:
workflow_dispatch:
pull_request:
push:
branches:
- master

jobs:
tests:
runs-on: ubuntu-latest

strategy:
matrix:
php-version: [ '8.1', '8.2' ]

name: Run tests on PHP v${{ matrix.php-version }}

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
extensions: pcntl

- name: Set composer cache directory
id: composer-cache
run: echo "COMPOSER_CACHE_DIRECTORY=$(composer config cache-files-dir)" >> $GITHUB_ENV

- name: Restore composer from cache
uses: actions/cache@v3
with:
path: ${{ env.COMPOSER_CACHE_DIRECTORY }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
restore-keys: ${{ runner.os }}-composer-

- name: Install composer dependencies
run: composer install --no-interaction --prefer-dist --no-progress

- name: Run phpunit tests
run: vendor/bin/phpunit --colors=always --testdox
3 changes: 3 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
"Aternos\\Taskmaster\\Test\\": "test/"
}
},
"require": {
"php": ">=8.1"
},
"require-dev": {
"phpunit/phpunit": "^10.4"
},
Expand Down
6 changes: 4 additions & 2 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions test/Task/SynchronizedFieldTask.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,12 @@ public function increaseCounter(): void
* @throws Throwable
*/
#[OnChild]
public function run(): null
public function run(): void
{
for ($i = 0; $i < $this->amount; $i++) {
$this->increaseCounter();
$this->call($this->increaseCounter(...));
}
return null;
}

/**
Expand Down

0 comments on commit a0e5295

Please sign in to comment.