Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the wiggler indivisible #875

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Set the wiggler indivisible #875

merged 2 commits into from
Dec 16, 2024

Conversation

lfarv
Copy link
Contributor

@lfarv lfarv commented Dec 12, 2024

This avoids a problem in plot_beta reported in #871 by setting a wiggler as "indivisible".

@lfarv lfarv added Python For python AT code bug fix labels Dec 12, 2024
@lfarv lfarv requested a review from swhite2401 December 12, 2024 14:26
@lfarv
Copy link
Contributor Author

lfarv commented Dec 12, 2024

@swhite2401: Not sure it works since I don't have a test case. Can you check?

@lfarv
Copy link
Contributor Author

lfarv commented Dec 12, 2024

The fix in Matlab is much more delicate. I'll look at it…

@lfarv
Copy link
Contributor Author

lfarv commented Dec 12, 2024

By the way, a "long" RF (rarely seen!) cavity has the same problem. If inactive, no problem, it's a drift. But if active, we should either set it "indivisible", or split the voltage!

UPDATE: no problem, it's split !

@swhite2401
Copy link
Contributor

Works on python!

@lfarv
Copy link
Contributor Author

lfarv commented Dec 14, 2024

Fixed on Matlab too, ready for merging!

Copy link
Contributor

@swhite2401 swhite2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested matlab, but python works nicely!

@lfarv lfarv merged commit b90e44d into master Dec 16, 2024
23 checks passed
@lfarv lfarv deleted the indivisible_wiggler branch December 16, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Python For python AT code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants