Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn connection unexpectedly closed #146

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

jchrys
Copy link
Collaborator

@jchrys jchrys commented Sep 18, 2023

Motivation:
To enhance the debugging experience, warning when a connection is unexpectedly closed.

Modifications:
Changed the log level to "warn" for unexpected connection closures

Result:
Improved log

Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchrys jchrys changed the title Warn connection is unexpectedly closed Warn connection unexpectedly closed Sep 18, 2023
Motivation:
To enhance the debugging experience, warning when a connection is unexpectedly closed.

Modifications:
Changed the log level to "warn" for unexpected connection closures

Result:
Improved log
@jchrys jchrys force-pushed the 1x-warn-when-connection-unexpectedly-closed branch from 7c0a98d to 8d702d1 Compare September 18, 2023 13:41
@jchrys jchrys merged commit 124a8d8 into trunk Sep 18, 2023
8 checks passed
@jchrys jchrys deleted the 1x-warn-when-connection-unexpectedly-closed branch September 18, 2023 13:44
@jchrys jchrys added this to the 1.0.3 milestone Sep 18, 2023
jchrys added a commit that referenced this pull request Sep 18, 2023
Motivation:
To enhance the debugging experience, warning when a connection is
unexpectedly closed.

Modifications:
Changed the log level to "warn" for unexpected connection closures

Result:
Improved log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants