Some functions in future module to no_std #696
Conversation
k-nasa
force-pushed
the
to_no_std_future_module
branch
from
a7eaa87 to
3883079
Compare
| @@ -23,15 +23,18 @@ use crate::task::{Context, Poll}; | |||
| /// # | |||
| /// # }) | |||
| /// ``` | |||
| pub async fn poll_fn<F, T>(f: F) -> T | |||
| pub fn poll_fn<F, T>(f: F) -> PollFn<F> | |||
There was a problem hiding this comment.
Hmm, I'm so-so about this change. Functions such as io::copy don't work on no-std either, but would be really useful to have as well. Having these functions be async fn was a bit of a deliberate choice when designing async-std.
With async await for embedded rust steadily progressing, I wonder how needed this is. It seems as async/await continues to move beyond mvp status this will be much of a non-issue.
All in all I think it'd be okay to leave these methods as-is for now. Thanks!
There was a problem hiding this comment.
Hm, the feature won't make the cut in 6 days, so it's at least 18 weeks out. Given that this is no user-visible change, I'd be fine with enabling embrio users to use this currently.
There was a problem hiding this comment.
Since the interface seen from the user does not change, I think that it is OK to change this.
|
|
||
| pub(crate) mod future; | ||
| mod ready; |
There was a problem hiding this comment.
I believe ready should be able to work in no-std.
Some functions in future module to no_std