Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a re-do of #650 for the current state of affairs where
ndcube
's plot() method exists onSpectrum1D
. After some testing, a group of us realized thendcube
plot doesn't really represent well what plotting should be doing for a Spectrum1D. So this PR movesplot_quick
to override the.plot()
of ndcube. A few others at the workshop will fill in a follow-on comment later with the experimentation that demonstrated to this group why this is a good idea.