Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specification of FITS suffixes in ImageFileCollection #727

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

keflavich
Copy link

Our observatory writes .FIT files, and there appears to be no way at
present to read these with an ImageFileCollection.


@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #727 (909b659) into master (9611aa9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   95.49%   95.51%   +0.02%     
==========================================
  Files          30       30              
  Lines        3931     3949      +18     
==========================================
+ Hits         3754     3772      +18     
  Misses        177      177              
Impacted Files Coverage Δ
ccdproc/image_collection.py 99.21% <100.00%> (+0.01%) ⬆️
ccdproc/tests/test_image_collection.py 98.88% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9611aa9...f1d6064. Read the comment docs.

@crawfordsm crawfordsm added this to the 2.1.1 milestone Jul 11, 2020
@mwcraig
Copy link
Member

mwcraig commented Jul 24, 2020

@keflavich -- do you have time to add a test for this? If not, I can do that Monday and then merge. I'm not sure why your files are not being picked up since fit was already supposed to be one of the recognized extensions but I'm 👍 on this feature in any event.

@keflavich
Copy link
Author

no time, sorry 🕐

keflavich and others added 3 commits March 15, 2021 10:23
This ensures that a refresh picks up the correct files, and avoids having
`extension=` arguments all over the place.
@mwcraig mwcraig force-pushed the fits_extension_specification branch from 82757fa to f1d6064 Compare March 15, 2021 16:27
@mwcraig mwcraig modified the milestones: 2.1.1, 2.2.0 Mar 15, 2021
Base automatically changed from master to main March 16, 2021 13:40
@mwcraig mwcraig modified the milestones: 2.2.0, 2.2.1 May 25, 2021
@mwcraig mwcraig modified the milestones: 2.2.1, 2.3 Nov 21, 2021
@mwcraig mwcraig modified the milestones: 2.3, 3.0 Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants