Merge pull request #831 from altair-above/gain_fix

Fixes #796 - cosmicray_lacosmic data type return
astropy · Jul 27, 2024 · 00b83fe · 00b83fe
2 parents 49d2657 + a7a6d8b
commit 00b83fe
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -31,6 +31,7 @@ Alphabetical list of code contributors
 * Christoph Deil (@cdeil)
 * Clément M.T. Robert (@neutrinoceros)
 * Timothy P. Ellsworth-Bowers (@tbowers7)
+* Allison Eto (@altair-above)
 * Forrest Gasdia (@fgasdia)
 * Carlos Gomez (@carlgogo)
 * Yash Gondhalekar (@Yash-10)

diff --git a/CHANGES.rst b/CHANGES.rst
@@ -21,6 +21,8 @@ Other Changes and Additions
 Bug Fixes
 ^^^^^^^^^
 
+- Fixes incorrect parameter passed to helper in ``cosmicray_lacosmic``. [#796]
+
 2.4.1 (2023-05-30)
 ------------------
 

diff --git a/ccdproc/core.py b/ccdproc/core.py
@@ -1572,7 +1572,7 @@ def cosmicray_lacosmic(ccd, sigclip=4.5, sigfrac=0.3,
 
         cleanarr = cleanarr - data_offset
         cleanarr = _astroscrappy_gain_apply_helper(cleanarr,
-                                                   gain,
+                                                   gain.value,
                                                    gain_apply,
                                                    old_astroscrappy_interface)
 
@@ -1613,7 +1613,7 @@ def cosmicray_lacosmic(ccd, sigclip=4.5, sigfrac=0.3,
 
         cleanarr = cleanarr - data_offset
         cleanarr = _astroscrappy_gain_apply_helper(cleanarr,
-                                                   gain,
+                                                   gain.value,
                                                    gain_apply,
                                                    old_astroscrappy_interface)