Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Unpin stuff, update matrix #8

Closed
wants to merge 3 commits into from
Closed

Conversation

pllim
Copy link
Member

@pllim pllim commented Sep 8, 2023

Might as well see where we're at while testing both numpy and matplotlib RCs.

Fix #6

Fix #7

@@ -34,8 +33,7 @@ deps =
reproject,all: git+https://github.com/astropy/reproject.git#egg=reproject[test,all]
specreduce,all: git+https://github.com/astropy/specreduce.git#egg=specreduce[test]
specutils,all: git+https://github.com/astropy/specutils.git#egg=specutils[all,test]
sunpy,all: SQLAlchemy<2
sunpy,all: git+https://github.com/sunpy/sunpy.git#egg=sunpy[tests,all]
sunpy,all: git+https://github.com/sunpy/sunpy.git#egg=sunpy[tests,asdf,dask,database,image,jpeg2000,map,net,timeseries,visualization]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does all not work? (Cc @Cadair)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is complaining no lxml so appears to be ignored. And I see fancy syntax now over at sunpy setup.cfg. So who knows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this change didn't help. Do you know why sunpy refuses to install its own dependencies here?

E ModuleNotFoundError: No module named 'lxml'

was bad idea. I do not want to deal with other packages warnings.
@pllim
Copy link
Member Author

pllim commented Sep 8, 2023

I am also not sure what to do with the astroquery failures. They are all about not catching deprecation warnings. Does not seem in scope to fix here, though ✔️ would be nice. cc @bsipocz

@bsipocz
Copy link
Member

bsipocz commented Sep 8, 2023

We do catch deprecation warnings, and devtest ci was passing earlier this week. Open one upstream if it's real, I maybe able to come back to it early next week.

@pllim
Copy link
Member Author

pllim commented Sep 8, 2023

Yeah, I don't think this is astroquery bug. I am just not sure how to set up the pytest settings here to be compatible with what astroquery is doing. Ideas welcome.

@pllim pllim closed this Nov 10, 2023
@pllim pllim deleted the unpin-me-maybe branch November 10, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin SQLAlchemy<2 when sunpy lets us MNT: Unpin tox < 4 when we can
3 participants