-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Unpin stuff, update matrix #8
Conversation
Also why astroquery warn did not show.
@@ -34,8 +33,7 @@ deps = | |||
reproject,all: git+https://github.com/astropy/reproject.git#egg=reproject[test,all] | |||
specreduce,all: git+https://github.com/astropy/specreduce.git#egg=specreduce[test] | |||
specutils,all: git+https://github.com/astropy/specutils.git#egg=specutils[all,test] | |||
sunpy,all: SQLAlchemy<2 | |||
sunpy,all: git+https://github.com/sunpy/sunpy.git#egg=sunpy[tests,all] | |||
sunpy,all: git+https://github.com/sunpy/sunpy.git#egg=sunpy[tests,asdf,dask,database,image,jpeg2000,map,net,timeseries,visualization] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does all not work? (Cc @Cadair)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is complaining no lxml
so appears to be ignored. And I see fancy syntax now over at sunpy setup.cfg
. So who knows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this change didn't help. Do you know why sunpy refuses to install its own dependencies here?
E ModuleNotFoundError: No module named 'lxml'
was bad idea. I do not want to deal with other packages warnings.
I am also not sure what to do with the astroquery failures. They are all about not catching deprecation warnings. Does not seem in scope to fix here, though ✔️ would be nice. cc @bsipocz |
We do catch deprecation warnings, and devtest ci was passing earlier this week. Open one upstream if it's real, I maybe able to come back to it early next week. |
Yeah, I don't think this is astroquery bug. I am just not sure how to set up the pytest settings here to be compatible with what astroquery is doing. Ideas welcome. |
Might as well see where we're at while testing both numpy and matplotlib RCs.
Fix #6
Fix #7