replace usages of copy_arrays with memmap for asdf>=3.1.0

[zacharyburnett]

follow-on to asdf-format/asdf#1797

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (f047a6b) to head (e686404).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          54       54           
  Lines        2050     2055    +5     
=======================================
+ Hits         2007     2012    +5     
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[braingram]

Hmmm... the oldestdeps should have failed here since asdf==2.13 (our minimum) doesn't have memmap:

asdf-astropy/pyproject.toml

Line 21 in dab5b4d

"asdf>=2.13",

It doesn't seem to even be running minimum_dependencies :-/ and is picking up asdf 3.3.0
https://github.com/astropy/asdf-astropy/actions/runs/9993708226/job/27621947749?pr=230#step:10:24

@zacharyburnett what do you think we should do here? The usage is only in tests so run-time asdf-astropy doesn't need asdf>=3.1.0 but if we fix our oldest deps it will start failing (since it uses the runtime requirements). The tests would also fail for anyone who packages this repository using the run-time requirements to run tests (like the asdf issue that came up yesterday). We could update the tests to check the asdf version (and use either copy_arrays or memmap) but I'm not sure if it's really worth it (although that would allow us to fix the oldestdeps and hopefully have it not fail).

[zacharyburnett]

Hmmm... the oldestdeps should have failed here since asdf==2.13 (our minimum) doesn't have memmap:

asdf-astropy/pyproject.toml

Line 21 in dab5b4d

"asdf>=2.13",

It doesn't seem to even be running minimum_dependencies :-/ and is picking up asdf 3.3.0
https://github.com/astropy/asdf-astropy/actions/runs/9993708226/job/27621947749?pr=230#step:10:24
@zacharyburnett what do you think we should do here? The usage is only in tests so run-time asdf-astropy doesn't need asdf>=3.1.0 but if we fix our oldest deps it will start failing (since it uses the runtime requirements). The tests would also fail for anyone who packages this repository using the run-time requirements to run tests (like the asdf issue that came up yesterday). We could update the tests to check the asdf version (and use either copy_arrays or memmap) but I'm not sure if it's really worth it (although that would allow us to fix the oldestdeps and hopefully have it not fail).

I think the only two options we have that maintain green status are

• remove oldestdeps testing or
• use copy_arrays or memmap based on version

I'm inclined toward the latter.

[braingram]

@zacharyburnett would you rebase this to (hopefully) allow the oldestdeps to use the oldest versions (now that #232 is in).

Also pre-commit is complaining of a RET505 error.
https://results.pre-commit.ci/run/github/271820376/1721656013.8blo7lrzSCa9pRAmDI-kog

[braingram]

Thanks!

[braingram]

Oh, looks like we don't have branch protection rules 😮 Let's wait for the CI to go green before merging.