Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call set_size_request on pane children #755

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

ibuclaw
Copy link
Contributor

@ibuclaw ibuclaw commented Jun 9, 2024

Otherwise the second child gets no width, and appears to be hidden when a thread is opened in pane view.

The number 300 is pretty arbitrary, it's taken as 1/4 of the default window width (set here).

Fixes #547

Otherwise the second child gets no width, and appears to be hidden when
a thread is opened in pane view.

Fixes astroidmail#547
@jorsn
Copy link
Member

jorsn commented Jun 14, 2024

Thanks, this works, and by default sets the pane size to half the window width.
300 seems pretty high to me, though, as it is the minimal width. Wouldn't 50 be enough?

Strangely enough, with only 20, the default width was smaller for me, maybe around the 300.

@jorsn jorsn merged commit 6de2c61 into astroidmail:master Jun 29, 2024
6 checks passed
@ibuclaw ibuclaw deleted the pane_set_size_request branch June 29, 2024 18:03
@ibuclaw
Copy link
Contributor Author

ibuclaw commented Jun 29, 2024

I can't remember the effect of setting it to 50. Did initially toy with various sizes, I noticed that when too small, it didn't split the window evenly into two, rather split 2/3 and 1/3. Value I ended up with I think is a quarter the default width. On my screen any smaller and threads become mostly unreadable, but with a different font that would obviously change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astroid pane view doesn't work anymore
2 participants