Allow conflicting extras in explicit index assignments #9160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables something like the "final boss" of PyTorch setups -- explicit support for CPU vs. GPU-enabled variants via extras:
It builds atop the conflicting extras work to allow sources to be marked as specific to a dedicated extra being enabled or disabled.
As part of this work, sources now have an
extra
field. If a source has anextra
, it means that the source is only applied to the requirement when defined within that optional group. For example,{ index = "torch-cpu", extra = "cpu" }
above only applies to"torch==2.5.1+cpu"
.The
extra
field does not mean that the source is "enabled" when the extra is activated. For example, this wouldn't work:In this case, the sources would effectively be ignored. Extras are really confusing... but I think this is correct? We don't want enabling or disabling extras to affect resolution information that's outside of the relevant optional group.