Support system-site-packages access when create venv #937
+85
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
reviewed
Mar 25, 2024
|
This would require some documentation. Also I'm assuming the only use for this flag is if this is used with an explicitly registered system python toolchain? |
|
Happy to pitch in if needed. I am using this PR for a very specific scenario along with a system toolchain, like you mentioned @mitsuhiko, and it's working great. |
bluss
reviewed
May 19, 2024
CHANGELOG.md
Outdated
| @@ -9,6 +9,9 @@ _Unreleased_ | |||
|
|
|||
| - Always create `.gitignore` file in `rye init`. #919 | |||
|
|
|||
| - Added new `rye.tool.system-site-packages` config, so that the virtualenv | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ischaojie
force-pushed
the
system-site-packages
branch
from
60d30db
to
2ef46fa
Compare
|
Ready for review :) |
ischaojie
changed the title
bluss
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration option to determine whether
system-site-packagesare required when creating a virtual environment, related: #925, astral-sh/uv#2101.