-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support uv --override option (#668) #1015
base: main
Are you sure you want to change the base?
Conversation
I'm not a fan of expanding scope, so don't do that, but |
a019cd7
to
a8937dc
Compare
Done |
6830807
to
501ed8f
Compare
e9d17a9
to
639bffe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I can review, but note I'm just a contributor and can't do more in this repo.
&requirements_file, | ||
lock_options.pre, | ||
env::var("__RYE_UV_EXCLUDE_NEWER").ok(), | ||
upgrade, | ||
keyring_provider, | ||
)?; | ||
} else { | ||
if overrides_file_in.is_some() { | ||
bail!("dependency overrides require the uv backend"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this maybe be a warning? Don't know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would ignore an explicit instruction to overwrite a dependency, I feel like it should be treated as an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a question of design, I don't know, on one hand the project is a pyproject.toml file which can be interpreted by standard python tools, not just Rye. And those tools would ignore everything inside tool.rye
anyway. Maybe error when rye is managing it is good yeah.
I don't think I can ask for reviewers. Your name was there because you've commented earlier. |
5585eb6
to
3365797
Compare
268e864
to
29c3fa9
Compare
This change will read an
override-dependencies
array from[tool.rye]
and propagate it as an--override
option touv
Example used in
test_overrides
:flask 3.0.0
requireswerkzeug>=3.0.0
but the override will enforce2.3.8
.