Bumped deprecated github actions uses + fixed client callback update

asticode · Sep 20, 2024 · b24155e · b24155e
1 parent c782b56
commit b24155e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -19,7 +19,7 @@ jobs:
 
     runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
 
     - if: ${{ runner.os == 'Windows' }}
       name: Set windows libsrt path
@@ -33,7 +33,7 @@ jobs:
 
     - name: Cache libsrt
       id: cache-libsrt
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: ${{ env.LIBSRT_PATH }}
         key: libsrt-${{ env.LIBSRT_VERSION }}-${{ runner.os }}
@@ -56,7 +56,7 @@ jobs:
         echo "DYLD_FALLBACK_LIBRARY_PATH=${{ env.LIBSRT_PATH }}/lib" >> $GITHUB_ENV
 
     - name: Set up Go
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v5
       with:
         go-version: '1.20'
 

diff --git a/pkg/client.go b/pkg/client.go
@@ -49,18 +49,18 @@ func Dial(o DialOptions) (c *Connection, err error) {
 		return
 	}
 
-	// Connect
-	if c.addr, err = s.Connect(o.Host, o.Port); err != nil {
-		err = fmt.Errorf("astisrt: connecting failed: %w", err)
-		return
-	}
-
 	// Set callbacks
 	if o.OnDisconnect != nil {
 		if err = s.SetConnectCallback(o.OnDisconnect.connectCallback(c)); err != nil {
 			err = fmt.Errorf("astisrt: setting connect callback failed: %w", err)
 			return
 		}
 	}
+
+	// Connect
+	if c.addr, err = s.Connect(o.Host, o.Port); err != nil {
+		err = fmt.Errorf("astisrt: connecting failed: %w", err)
+		return
+	}
 	return
 }