-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcpkg support #26
vcpkg support #26
Conversation
This PR lays the groundwork for vcpkg integration. The parts of the code that are meant to be executed only when packaged via vcpkg are put behind `ASMJIT_EXTERNAL` flag. The support is implemented in a manner that closely mirrors asmjit's support. I have tested this configuration with asmtk port in local vcpkg repo, and it worked flawlessly. Once those changes are merged, I will open a PR in vcpkg repo with portfiles for asmtk. This PR would be instrumental in closing #25 and microsoft/vcpkg#24359
just for tracking this is required to resolve #25 |
Thanks, I have reviewed this and I think it's okay. |
Nice. Could you tell us what is preventing this from being merged? |
I think |
The specific generator can be specified via CMakeSettings.json (alongside the CMakeLists.txt). I actually just had this exact 'visual studio not found error' locally funny enough. It was caused by my CMakeSettings.json specifying to use the vs 2019 generator, while I had vs 2022 installed. Here's an example settings file for vs 2022
|
I think the faulty compiler configuration is specified in the CI config: asmtk/.github/workflows/build.yml Line 17 in 53b251c
|
Thanks! I will fix the CI later. |
This PR lays the groundwork for vcpkg integration. The parts of the code that are meant to be executed only when packaged via vcpkg are put behind
ASMJIT_EXTERNAL
flag. The support is implemented in a manner that closely mirrors asmjit's support. I have tested this configuration with asmtk port in local vcpkg repo, and it worked flawlessly. Once those changes are merged, I will open a PR in vcpkg repo with portfiles for asmtk.This PR would be instrumental in closing #25 and microsoft/vcpkg#24359