Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on cdb_make_free function… #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ludrao
Copy link

@ludrao ludrao commented Feb 4, 2017

cdb_make_finish is a tinycdb private function so it is not exported. The public function cdb_make_finish calls it anyway.
This pull request helps using lcdb with a shared library without having to modify tinycdb code.

@ludrao
Copy link
Author

ludrao commented Feb 8, 2017

I mixed up the topic in the same master branch in my repo, so this pull request actually address 3 different issues:

  • remove dependency on tinycdb internal function
  • fix an actual bug that make lua-tinycdb write in global environment and prevent having several opened cdb.make isntances
  • enable overwrite flag in cdb.make() API
    Let me know if you have a concern with one of this 3 changes and would like to apply them separatly.

@ludrao
Copy link
Author

ludrao commented Feb 8, 2017

This PR fixes issue #2

@tubby1981
Copy link

tubby1981 commented Jan 8, 2021

Thank you folays for these commits. lua-tinycdb is working with lua5.2 with these changes.

The only error I got with example.lua is:

free(): invalid pointer
Aborted (core dumped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants