Chart: Fix runtimeClassName for KE (apache#34631)

asapekia · Sep 26, 2023 · 9730dba · 9730dba
1 parent a09d0c4
commit 9730dba
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/chart/files/pod-template-file.kubernetes-helm-yaml b/chart/files/pod-template-file.kubernetes-helm-yaml
@@ -90,7 +90,7 @@ spec:
   priorityClassName: {{ .Values.workers.priorityClassName }}
   {{- end }}
   {{- if .Values.workers.runtimeClassName }}
-  priorityClassName: {{ .Values.workers.runtimeClassName }}
+  runtimeClassName: {{ .Values.workers.runtimeClassName }}
   {{- end }}
   {{- if or .Values.registry.secretName .Values.registry.connection }}
   imagePullSecrets:

diff --git a/helm_tests/airflow_aux/test_pod_template_file.py b/helm_tests/airflow_aux/test_pod_template_file.py
@@ -792,3 +792,14 @@ def test_termination_grace_period_seconds(self):
         )
 
         assert 123 == jmespath.search("spec.terminationGracePeriodSeconds", docs[0])
+
+    def test_runtime_class_name_values_are_configurable(self):
+        docs = render_chart(
+            values={
+                "workers": {"runtimeClassName": "nvidia"},
+            },
+            show_only=["templates/pod-template-file.yaml"],
+            chart_dir=self.temp_chart_dir,
+        )
+
+        assert jmespath.search("spec.runtimeClassName", docs[0]) == "nvidia"